430 configurable config file via build flags#433
Merged
Donnie-Ice merged 2 commits intodevfrom Mar 25, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #433 +/- ##
==========================================
- Coverage 75.97% 75.72% -0.25%
==========================================
Files 81 81
Lines 22263 22742 +479
Branches 1807 1853 +46
==========================================
+ Hits 16914 17222 +308
- Misses 4707 4845 +138
- Partials 642 675 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dccutrig
approved these changes
Mar 24, 2025
Contributor
dccutrig
left a comment
There was a problem hiding this comment.
I reviewed these as Donnie wrote them and we agreed on them. Some external thoughts would be nice to see if we arrive at the same conclusions.
rjbrown2
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Changes to Core Features:
How do you test these changes?
Modify build script with
-DFOO_BAR=XXand then print out the define in a unit test. Comment if you think any of the others should be converted to build flags.API Changes:
N/A