Skip to content

Fix #117, Replaces strncpy and strlen#119

Merged
dzbaker merged 1 commit intonasa:mainfrom
chillfig:SA_jsc2_1
Jul 2, 2024
Merged

Fix #117, Replaces strncpy and strlen#119
dzbaker merged 1 commit intonasa:mainfrom
chillfig:SA_jsc2_1

Conversation

@chillfig
Copy link
Copy Markdown
Contributor

@chillfig chillfig commented Jun 10, 2024

Checklist (Please check before submitting)

Describe the contribution

Testing performed
N/A

Expected behavior changes
N/A

System(s) tested on
N/A

Additional context
Depends on nasa/osal#1465

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems

@chillfig
Copy link
Copy Markdown
Contributor Author

Add snprintf replacement

@chillfig chillfig changed the title Fix #117, Adds JSC 2.1 Static Analysis comments Fix #117, Replaces strncpy with snprintf Jun 14, 2024
@chillfig
Copy link
Copy Markdown
Contributor Author

Add snprintf replacement

Edit: snprintf has been added

@chillfig chillfig force-pushed the SA_jsc2_1 branch 3 times, most recently from 23e2ba1 to 4e7796a Compare June 18, 2024 18:07
@chillfig chillfig changed the title Fix #117, Replaces strncpy with snprintf Fix #117, Replaces strncpy and strlen Jun 18, 2024
@chillfig chillfig mentioned this pull request Jun 24, 2024
2 tasks
This commit addresses issues flagged during static analysis by:
- Replacing strncpy with snprintf to enhance safety and compliance.
- Replacing strlen with OS_strnlen.
@dzbaker
Copy link
Copy Markdown
Contributor

dzbaker commented Jun 27, 2024

CCB 27 June 2024: Will re-run workflows once osal#1465 is merged in to verify they pass.

@dzbaker dzbaker merged commit 1f8e29a into nasa:main Jul 2, 2024
@dzbaker dzbaker added this to the v7.0.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static Code Analysis JSC 2.1

2 participants