fix #120, address sanitizer issue in fm_dispatch unit test#121
Merged
fix #120, address sanitizer issue in fm_dispatch unit test#121
Conversation
Contributor
|
CCB 20 June 2024: Approved pending review by @jphickey. |
Fix nasa#120, fix passing in null as parameter in unit test
2d2f1ac to
55bdfb0
Compare
Author
|
updated to amend commit message. @dzbaker can you rerun the workflow? |
Contributor
|
CCB 8 August 2024: Approving at recommendation of @jphickey. |
jphickey
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #120, fix passing in null as parameter in unit test
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
fixes Address Sanitizer issue in coverage-fm-fm_dispatch #120, fix run time error with address sanitizer.
Testing performed
Steps taken to test the contribution:
Add the following option:
add_compile_options(
-fsanitize=address
-fsanitize=undefined
-fsanitize-recover=all
-g
)
add_link_options(
-fsanitize=address
-fsanitize=undefined
-fsanitize-recover=all
)
Make SIMULATION=native ENABLE_UNIT_TESTS=true prep
make install
Run Test
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)
Anh Van, GSFC