Fix #118, Standardize command responses#122
Merged
Conversation
pepepr08
approved these changes
Oct 24, 2024
Contributor
|
@thnkslprpt Thank you for the contribution! Would you be able to resolve the merge conflicts? |
0211fed to
433f557
Compare
Contributor
Author
@dzbaker updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
RESETcommand changed toINFOtypeAs per the discussion in the issue, most of the first list were already fixed, and the 2nd list I have left alone to maintain consistency - of the 8 'partial success' events that increment the
ChildCmdWarnCounter, all areINFORMATIONtype, exceptFM_GET_FILE_INFO_OPEN_ERR_EIDwhich is ofERRORtype (perhaps need a separate issue to align this).Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
As above.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt