Skip to content

Fix #123, declare FilenameState as uint32#124

Merged
dzbaker merged 1 commit intonasa:mainfrom
thnkslprpt:fix-123-declare-FilenameState-as-uint32
Aug 15, 2025
Merged

Fix #123, declare FilenameState as uint32#124
dzbaker merged 1 commit intonasa:mainfrom
thnkslprpt:fix-123-declare-FilenameState-as-uint32

Conversation

@thnkslprpt
Copy link
Copy Markdown
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
No change with current logic - but avoids future issues if FM_SetPermissionsCmd is updated.

System(s) tested on
Debian 12 using the current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

Copy link
Copy Markdown
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Looks good.

FM_SetPermissionsCmd will only check if the FilenameState is 0 but agreed that the logic should follow consistency to prevent future confusion.

@dzbaker dzbaker merged commit e0d502a into nasa:main Aug 15, 2025
16 checks passed
@thnkslprpt thnkslprpt deleted the fix-123-declare-FilenameState-as-uint32 branch August 19, 2025 05:22
@dzbaker dzbaker added this to the v7.0.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FilenameState in FM_SetPermissionsCmd should be declared as uint32 type

3 participants