Added Profile Load Estimator #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teubert
added
A: Load Estimation
inc/Exceptions.h
Outdated
| /** @brief Defines a type of object to be thrown as exception. It reports | ||
| * errors that are due to out of range element access | ||
| */ | ||
| class OutOfRangeError : public std::out_of_range { |
Contributor
There was a problem hiding this comment.
Is there a benefit to this over throwing std::out_of_range directly?
src/Loading/ProfileLoadEstimator.cpp
Outdated
|
|
||
| uint32_t nElements = config.getUInt32(LOADING_LEN_KEY); | ||
|
|
||
| profile.resize(nElements); |
Contributor
There was a problem hiding this comment.
To minimize the unnecessary construction of temporary elements, use profile.reserve(nElements) here and profile.emplace_back(duration_s, inputs) inside the loop.
src/Loading/ProfileLoadEstimator.cpp
Outdated
| } | ||
|
|
||
| LoadEstimator::LoadEstimate ProfileLoadEstimator::estimateLoad(const double t_s) { | ||
| const static double startT_s = t_s; |
Contributor
There was a problem hiding this comment.
I don't think this is doing what it's supposed to. This creates a single startT_s variable shared by all instances of the class. Should be replaced double and bool member variable.
| void registerConstLoadEstimatorTests(TestContext& context); | ||
| void registerGaussianLoadEstimatorTests(TestContext& context); | ||
| void registerMovingAverageLoadEstimatorTests(TestContext& context); | ||
| void profileTest() { |
Contributor
There was a problem hiding this comment.
For the sake of consistency, shouldn't this go in its own file like all of the other individual tests?
jason-watkins
added
S: Waiting on Author
jason-watkins
approved these changes
Jul 30, 2020
jason-watkins
added
S: Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.