Skip to content

Open Source Draco Release#78

Merged
dzbaker merged 1 commit into
mainfrom
draco-integration
Jan 22, 2026
Merged

Open Source Draco Release#78
dzbaker merged 1 commit into
mainfrom
draco-integration

Conversation

@dzbaker
Copy link
Copy Markdown
Contributor

@dzbaker dzbaker commented Jan 15, 2026 •
edited
Loading

NASA Docket No. GSC-19,200-1, and identified as "cFS Draco"
Batch update of latest cFS software release

Reflects commit dcf2324cf56d27f9f49efeb2294ca279d1a28388 from NASA internal development repo

@jphickey jphickey force-pushed the draco-integration branch 2 times, most recently from f371311 to 2ad0206 Compare January 22, 2026 23:16
github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 22, 2026
View reviewed changes
Comment thread config/default_hk_fcncode_values.h
#ifndef DEFAULT_HK_FCNCODE_VALUES_H
#define DEFAULT_HK_FCNCODE_VALUES_H

#define HK_CCVAL(x) HK_FunctionCode_##x

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro HK_CCVAL(x) uses token pasting and is not allowed.
Comment thread config/default_hk_interface_cfg_values.h
#define DEFAULT_HK_INTERFACE_CFG_VALUES_H

/* Use the default configuration value for all */
#define HK_INTERFACE_CFGVAL(x) DEFAULT_HK_INTERFACE_##x

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro HK_INTERFACE_CFGVAL(x) uses token pasting and is not allowed.
Comment thread config/default_hk_internal_cfg_values.h
#define DEFAULT_HK_INTERNAL_CFG_H

/* Use the default configuration value for all */
#define HK_INTERNAL_CFGVAL(x) DEFAULT_HK_INTERNAL_##x

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro HK_INTERNAL_CFGVAL(x) uses token pasting and is not allowed.
Comment thread config/default_hk_msgid_values.h
#include "cfe_core_api_base_msgids.h"
#include "hk_topicids.h"

#define CFE_PLATFORM_HK_CMD_MIDVAL(x) CFE_PLATFORM_CMD_TOPICID_TO_MIDV(CFE_MISSION_HK_##x##_TOPICID)

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro CFE_PLATFORM_HK_CMD_MIDVAL(x) uses token pasting and is not allowed.
Comment thread config/default_hk_msgid_values.h
#include "hk_topicids.h"

#define CFE_PLATFORM_HK_CMD_MIDVAL(x) CFE_PLATFORM_CMD_TOPICID_TO_MIDV(CFE_MISSION_HK_##x##_TOPICID)
#define CFE_PLATFORM_HK_TLM_MIDVAL(x) CFE_PLATFORM_TLM_TOPICID_TO_MIDV(CFE_MISSION_HK_##x##_TOPICID)

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro CFE_PLATFORM_HK_TLM_MIDVAL(x) uses token pasting and is not allowed.
Comment thread fsw/src/hk_dispatch.c
/* Process a command pipe message */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void HK_AppPipe(const CFE_SB_Buffer_t *BufPtr)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
Comment thread fsw/src/hk_utils.c
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t HK_ProcessNewCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)
CFE_Status_t HK_ProcessNewCopyTable(HK_CopyTableEntry_t *CpyTblPtr, HK_RuntimeTableEntry_t *RtTblPtr)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
Comment thread fsw/src/hk_utils.c
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t HK_ProcessNewCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)
CFE_Status_t HK_ProcessNewCopyTable(HK_CopyTableEntry_t *CpyTblPtr, HK_RuntimeTableEntry_t *RtTblPtr)

Check notice

Code scanning / CodeQL

Function too long Note

HK_ProcessNewCopyTable has too many lines (141, while 60 are allowed).
Comment thread fsw/src/hk_utils.c
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t HK_TearDownOldCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)
CFE_Status_t HK_TearDownOldCopyTable(HK_CopyTableEntry_t *CpyTblPtr, HK_RuntimeTableEntry_t *RtTblPtr)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
Comment thread fsw/src/hk_utils.c
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t HK_TearDownOldCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)
CFE_Status_t HK_TearDownOldCopyTable(HK_CopyTableEntry_t *CpyTblPtr, HK_RuntimeTableEntry_t *RtTblPtr)

Check notice

Code scanning / CodeQL

Function too long Note

HK_TearDownOldCopyTable has too many lines (91, while 60 are allowed).
@jphickey
NASA Docket No. GSC-19,200-1, and identified as "cFS Draco"
8212a00 
Batch update of latest cFS software release

Reflects commit dcf2324cf56d27f9f49efeb2294ca279d1a28388 from NASA internal development repo
@jphickey jphickey marked this pull request as ready for review January 22, 2026 23:33
@dzbaker dzbaker merged commit 6c7b88b into main Jan 22, 2026
13 checks passed
@dzbaker dzbaker added this to the v7.0.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jphickey jphickey jphickey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dzbaker @jphickey @github-advanced-security @keegan-moore