Skip to content

Fix #1929, Remove redundant status check in CFE_ES_RegisterCDSEx()#2329

Merged
dzbaker merged 1 commit intonasa:mainfrom
thnkslprpt:fix-1929-remove-redundant-status-check-in-CFE_ES_RegisterCDSEx
Nov 5, 2024
Merged

Fix #1929, Remove redundant status check in CFE_ES_RegisterCDSEx()#2329
dzbaker merged 1 commit intonasa:mainfrom
thnkslprpt:fix-1929-remove-redundant-status-check-in-CFE_ES_RegisterCDSEx

Conversation

@thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented May 6, 2023

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
This PR (slightly) increases coverage by one branch by removing an unreachable branch.

Expected behavior changes
No change to behavior.

Contributor Info
Avi Weiss @thnkslprpt

@pepepr08 pepepr08 self-requested a review October 24, 2024 18:44
@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label Oct 24, 2024
@dzbaker dzbaker merged commit 012ca67 into nasa:main Nov 5, 2024
@thnkslprpt thnkslprpt deleted the fix-1929-remove-redundant-status-check-in-CFE_ES_RegisterCDSEx branch November 5, 2024 18:40
@dzbaker dzbaker added this to the v7.0.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ES missing branch in CFE_ES_RegisterCDSEx, overwrite success check doesn't make sense

3 participants