Fix nasa/cFS#812, Update Upload Artifact Version#2631
Merged
Conversation
dzbaker
added
the
CCB:Approved
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes nasa/cFS#812
Testing performed
https://github.com/arielswalker/cFE/actions/runs/12916125161
Expected behavior changes
Functional tests workflow will not fail due to outdated upload artifacts version.
System(s) tested on
GitHub Actions
Additional context
This article, https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/, states:
"This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers."
Only the opensource workflows should be updated to use the latest version, v4. The internal workflows will fail if using v4 as seen below so it should continue to use v3.
This wiki, https://github.com/actions/upload-artifact, states:
"upload-artifact@v4+ is not currently supported on GHES yet. If you are on GHES, you must use v3."
Third party code
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Walker, MCSG TECH.