Fix #92 - Update lgtm.yml to exclude Ui files #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
approved these changes
May 29, 2020
Contributor
|
CCB-2020-06-03: @lbleier-GSFC Look into using GitHub's "release" feature to package UI files |
Contributor
|
I'd suggest we GitHub's "Release" for official releases and the associated documentation. I'd prefer the deployment model, for which you can deploy artifacts created by travis to a github branch (master could just have the code with .gitignore for all the autogenerated elements, deployed branch could include the generated artifacts from the latest master). |
Contributor
|
There's the concept of pre release which i think we can leverage.
I think we can use something like the "nightly" concept in the discussion below and automate it via Travis or GitHub actions. We can call it "latest" or "development".
We probably need to discuss distribution and models and use cases though.
https://github.community/t/nightly-builds-latest-branch-releases/725
…-------- Original Message --------
From: skliper <notifications@github.com>
Date: Wed, June 03, 2020 2:09 PM -0400
To: nasa/cFS <cFS@noreply.github.com>
CC: "Cruz-Ortiz, Gerardo E. (GSFC-5820)" <gerardo.e.cruz-ortiz@nasa.gov>, State change <state_change@noreply.github.com>
Subject: [EXTERNAL] Re: [nasa/cFS] Fix #92 - Update lgtm.yml to exclude Ui files (#94)
I'd suggest we GitHub's "Release" for official releases and the associated documentation. I'd prefer the deployment model, for which you can deploy artifacts created by travis to a github branch (master could just have the code with .gitignore for all the autogenerated elements, deployed branch could include the generated artifacts from the latest master).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_nasa_cFS_pull_94-23issuecomment-2D638369134&d=DwMCaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=uGHHRLa6OomHv_0t046KAURugmkGgaXQU_MIoG3vt4OSC-EL5NOT7qoGkIeI5UDt&m=kbi_Gdx8Gi1GXqRtv-k6IYgU6OEpBLLqfJe8q2xypoc&s=YhHVI27X4y-OlOBNFbSV0hpng-Zk5m048Gj9u6Rc1m4&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOG3GCMLBRXC7A7MTXE3M4LRU2GSTANCNFSM4NOBY3VQ&d=DwMCaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=uGHHRLa6OomHv_0t046KAURugmkGgaXQU_MIoG3vt4OSC-EL5NOT7qoGkIeI5UDt&m=kbi_Gdx8Gi1GXqRtv-k6IYgU6OEpBLLqfJe8q2xypoc&s=dg_e54a6onk4yvQ_MV_RHgnppAeoF9puZAAlW1Y3Va4&e=>.
|
Contributor
Author
|
For the issue at hand, I believe the best course of action would be to have the Ui_ files be created during the overall make process. I will create a new issue for this, and see what I can do |
This was referenced Jul 27, 2020
yammajamma
added a commit
that referenced
this pull request
Sep 21, 2020
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
Nothing outside of the codec code should need to know about the bitfields in the CFDP protocol definition. Everything else uses logical values. This moves all DECLARE_FIELD macros into cf_codec.c and removes cf_field.h.
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
Fix nasa#94, move all bitfields into codec
jphickey
pushed a commit
to jphickey/cFS
that referenced
this pull request
Jun 2, 2025
Open Source Updates for Equuleus-rc1+dev23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #92 to exclude files in cFS-GroundSystem with the
Ui_prefixTesting performed
Steps taken to test the contribution:
Pending lgtm run
Expected behavior changes
lgtm analysis should not include
Ui_filesCode contibutions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.
Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleier, NASA GSFC\Code 582