solver: align equilibrium/rocket/shock iteration behavior with legacy CEA2 and expand CI coverage#28
Merged
markleader merged 51 commits intonasa:mainfrom Feb 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the equilibrium, rocket, and shock solvers to better match legacy CEA2 iteration behavior and edge-case handling, with a focus on singular recovery, condensed-species activation/order, frozen-flow scheduling, and convergence criteria. It also updates CI to build/test across a broader compiler/OS matrix and publish build artifacts for tagged releases.
Changes
source/equilibrium.f90max_iterations,esize,pidenominator guards, and absolute-value mole checks) to better track legacy behavior.source/rocket.f90pi/pandAe/Atpoints and ensured omitted points do not consume output indices.source/shock.f90.github/workflows/basic_build.ymlFC.CHANGELOG.mdTesting
Compatibility / Numerical behavior