Fix failing transport property cases#37
Merged
markleader merged 5 commits intonasa:mainfrom Feb 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addressing failing transport problems identified by @immamex in Issue #34.
Fix transport-property failures and legacy-behavior mismatches in CH4/O2 equilibrium/rocket cases, including an out-of-bounds crash path and interval-selection differences.
Changes
compute_transport_propertiesby replacing sparsepure_idxlogic with explicit aligned maps and reverse lookup.transport_to_localto skip unmapped pairs (prevents OOB).transport.f90.Testing
ctest,pytest, andtest_main.pywith expected outputs.Compatibility / Numerical behavior