Fix CLI output formatting regressions in main.f90 (dynamic species formats, legacy-aligned headers, and ratio reporting)#45
Merged
markleader merged 2 commits intonasa:mainfrom Feb 25, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes output-formatting issues in the main interface, including Issue #35 (format buffer overflow crash), and improves legacy compatibility of generated
.outfiles by aligning section ordering/headers and table column layout.Changes
thermo_outputrocket_outputshock_outputdeton_outputget_eq_species_formatget_rocket_species_formatget_shock_species_formatget_deton_species_formatCASE = ...line before data tables.-1) with computed/parsed values in thermo and rocket reactant tables.pi/p,subar,supar).PERFORMANCE PARAMETERSrows with the station column gridcompute_fuel_ratios:%fueland%fO/F/% Fuelfrom reactant amounts when noof_scheduleis present********) in% Fuelformattingna) cases safelyTesting
example1(thermo)example6(detonation)example7(shock)example8,example9(rocket IAC/FAC)example11,example13,example14(fuel-ratio edge cases)test_main.pywith expected outputs.Compatibility / Numerical behavior