Improve input parsing backwards-compatibility#48
Merged
markleader merged 3 commits intonasa:mainfrom Feb 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve
reacinput compatibility with legacy CEA2 behavior, fix #25 so that user-provided reactant enthalpy overrides so they are honored at runtime.Changes
source/input.f90read_input/read_problemflow to avoid EOF/trailing-line parsing crash.read_problemto subroutine-style output and adjustedread_inputhandling accordingly.problems = problems(1:n-1)shrink with allocate/copy/move_alloc.reacparsing compatibility:den...density alias support in addition torho...,g/ccwhen omitted,wt/mol,wt/mole,molwt,mwt,mw) with unit conversion/validation,1.0,namereactants,reacdataset.H,O) are not misclassified as enthalpy tokens.source/main.f90apply_reactant_thermo_overridesand applied it after reactant mixture creation in all relevant execution paths.h,...) overrides thermo-fit reference values, including for database species.compute_reactant_enthalpy(prob%reactants(i)instead of always index 1).source/input_test.pfreackeywords/tokens.Testing
ctest -R cea_core_test -Vpython test_main.pyCompatibility / Numerical behavior
Expected numerical/output changes are limited to inputs that explicitly rely on new/changed behavior:
reacforms (e.g., missing named-reactant amounts,denalias, molecular-weight aliases, implicit formula coefficients, case variants) now parse/behave in a CEA2-compatible way.