Handle missing implementation when resampling#76
Closed
Conversation
…e. override include_output if implemention is missing in resample
… into handle-no-implementation
ixjlyons
reviewed
Apr 8, 2026
| new_self = model.__new__(model) | ||
| new_self.implementation = self.implementation | ||
| # TODO: add option to rebuild the implemention | ||
| if getattr(self, "implementation", False): |
Contributor
There was a problem hiding this comment.
Try hasattr(self, "implementation") for just checking whether or not the attribute exists
| if getattr(self, "implementation", False): | ||
| new_self.implementation = self.implementation | ||
| else: # override include_output if implementation is not found | ||
| include_output = False |
Contributor
There was a problem hiding this comment.
If we aren't (yet) automatically constructing the implementation, this should probably emit a warning (only if the user set include_output=True).
Contributor
|
Merging this into #73 and will handle there |
This was referenced Apr 10, 2026
Contributor
|
Closing since this was incorporated into #73. Thought it would auto close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
TrajectoryAnalysisin parallel/pickled function, implementation is missing. Resampling withinclude_output=Truerequires the implementation. Changes toresample()to only assign the implementation to the resampled sim only if it exists, and overridesinclude_outputtoFalseif the implementation is missing. Added aTODO:to optionally reconstruct the implementation.