Skip to content

CI and linting updates#8

Merged
sixpearls merged 27 commits intomainfrom
ci-updates
Jun 6, 2025
Merged

CI and linting updates#8
sixpearls merged 27 commits intomainfrom
ci-updates

Conversation

@ixjlyons
Copy link
Copy Markdown
Contributor

@ixjlyons ixjlyons commented Jun 4, 2025 •
edited
Loading

  • Use dependency groups instead of optional dependencies
  • Run linting and formatting in CI
  • Add quite a few rule sets and update code accordingly
  • Add a pre-commit config (can run the same checks as CI with pre-commit run -a, optionally install the git hooks)
  • Holding off on pep8-naming and pydoclint for now

ixjlyons added 22 commits June 4, 2025 08:55
@ixjlyons
Lint in CI, output coverage, switch to dependency groups
63b5654
@ixjlyons
Fixups
0423bc6
@ixjlyons
Initial round of fixes with pre-commit run -a
a888f83
@ixjlyons
Fixes for pycodestyle (E) rules
3e3d873
@ixjlyons
Fixes for pyflakes (F) and pycodestyle (W) rules
d09073d
@ixjlyons
Fixes for flake8-bandit (S) rules
a370492
@ixjlyons
Fixes for flake8-bugbear rules
afd5708
@ixjlyons
Revert wrapping spline eval function with partial
852a2a8 
Since the function is used immediately in the for loop, the loop index
updates as needed and the lint error is a false postiive
@ixjlyons
Fixes for flake8-pytest-style (PT) rules
a71b06d
@ixjlyons
Fixes for flake8-simplify (SIM) rules
7a87029
@ixjlyons
fixup
319f08a
@ixjlyons
Fixes for numpy (NPY) rules
d7c1ec0
@ixjlyons
Fixes for perflint (PERF) rules
312f1b7
@ixjlyons
Fixes for flake8-errmsg (EM) rules
2b3531f
@ixjlyons
Fixes for pylint (PL) rules
529b5a2
@ixjlyons
Fixes for pyupgrade (UP) rules
5e8b72d
@ixjlyons
Cleanup
213bae1
@ixjlyons
Specify full pre-commit action version
d9a477a
@ixjlyons
Put multiprocessing calls under name=main block
30320b7
@ixjlyons
Update ignores
3e6950b
@ixjlyons
Minor fixups from looking through diff wrt main
192cbd6
@ixjlyons
Fetch all history for docs build to get version right
1336d24
@ixjlyons ixjlyons requested a review from sixpearls June 4, 2025 18:44
@sixpearls
Copy link
Copy Markdown
Contributor

sixpearls commented Jun 4, 2025

Let's do pep8-naming now, agree to deferring pydoclint

@ixjlyons
Copy link
Copy Markdown
Contributor Author

ixjlyons commented Jun 5, 2025

Should be good now

ixjlyons
ixjlyons commented Jun 5, 2025
View reviewed changes
@sixpearls sixpearls merged commit c55207a into main Jun 6, 2025
19 checks passed
@ixjlyons ixjlyons deleted the ci-updates branch June 6, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sixpearls sixpearls sixpearls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ixjlyons @sixpearls