We should disallow duplicate entries of the same phase number in component instance specifiers.
For example:
instance rateGroupDriver: Svc.RateGroupDriver base id FixedBaseIds.NO_DICTIONARY \
{
phase Fpp.ToCpp.Phases.configConstants """
// The reference topology divides the incoming clock signal 10Hz
Svc::RateGroupDriver::DividerSet rateGroupDivisors{{{1, 0}, {10, 0}, {100, 0}}};
"""
phase Fpp.ToCpp.Phases.configConstants """
// Rate group driver needs a divisor list
rateGroupDriver.configure(rateGroupDivisors);
"""
}
This was a bug I had where I had duplicate entries of configConstants, the second entry should have been configComponents. It made it to C++ and gave be an odd (which wasn't very odd once I saw this typo) error about rateGroupDivisors being undefined. I think it would be reasonable to catch this at FPP-time.
We should disallow duplicate entries of the same phase number in component instance specifiers.
For example:
This was a bug I had where I had duplicate entries of
configConstants, the second entry should have beenconfigComponents. It made it to C++ and gave be an odd (which wasn't very odd once I saw this typo) error aboutrateGroupDivisorsbeing undefined. I think it would be reasonable to catch this at FPP-time.