Skip to content

Implement Type Alias codegen#645

Merged
bocchino merged 17 commits intomainfrom
issue-622-type-alias-impl
Mar 18, 2025
Merged

Implement Type Alias codegen#645
bocchino merged 17 commits intomainfrom
issue-622-type-alias-impl

Conversation

@Kronos3
Copy link
Copy Markdown
Collaborator

@Kronos3 Kronos3 commented Mar 3, 2025 •
edited
Loading

Closes #622

@Kronos3 Kronos3 requested a review from bocchino March 4, 2025 05:02
bocchino
bocchino reviewed Mar 6, 2025
View reviewed changes
Comment thread compiler/lib/src/main/scala/codegen/ComputeGeneratedFiles.scala
bocchino
bocchino reviewed Mar 6, 2025
View reviewed changes
Comment thread compiler/lib/src/main/scala/codegen/CppWriter/AliasCppWriter.scala Outdated
bocchino
bocchino reviewed Mar 6, 2025
View reviewed changes
Comment thread compiler/lib/src/main/scala/codegen/CppWriter/AliasCppWriter.scala Outdated
bocchino
bocchino reviewed Mar 6, 2025
View reviewed changes
Comment thread compiler/tools/fpp-to-cpp/test/alias/TAliasAc.ref.h Outdated
@Kronos3 Kronos3 mentioned this pull request Mar 17, 2025
Closed
Kronos3
Kronos3 commented Mar 17, 2025
View reviewed changes
Comment thread compiler/tools/fpp-to-cpp/test/component/test-impl/check-cpp
@Kronos3 Kronos3 requested a review from bocchino March 17, 2025 19:57
bocchino
bocchino reviewed Mar 17, 2025
View reviewed changes
Comment thread compiler/lib/src/main/scala/codegen/CppWriter/AliasCppWriter.scala Outdated
@Kronos3
Use FpConfig instead of FppConfig, update tests to generate .cpp file…
0804409 
…s so that they may be cpp-checked. Fix builtin type alias handling
Kronos3
Kronos3 commented Mar 17, 2025
View reviewed changes
Comment thread compiler/lib/src/main/scala/codegen/CppWriter/CppWriterState.scala
Kronos3
Kronos3 commented Mar 17, 2025
View reviewed changes
Comment thread compiler/lib/src/main/scala/codegen/CppWriter/CppWriterState.scala
bocchino
bocchino reviewed Mar 18, 2025
View reviewed changes
Comment thread compiler/tools/fpp-to-cpp/test/component/base/TypedReturnPortAc.ref.cpp
@bocchino bocchino self-requested a review March 18, 2025 20:24
bocchino
bocchino approved these changes Mar 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino
Copy link
Copy Markdown
Collaborator

bocchino commented Mar 18, 2025

The fpp-check tests pass against this F Prime branch: nasa/fprime#3393.

@bocchino bocchino merged commit 66ab6dd into main Mar 18, 2025
11 checks passed
@bocchino bocchino deleted the issue-622-type-alias-impl branch March 18, 2025 20:33
@Kronos3 Kronos3 mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bocchino bocchino bocchino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement and test C++ code generation for type aliases

2 participants

@Kronos3 @bocchino