Skip to content

Conversation

@bocchino
Copy link
Collaborator

@bocchino bocchino commented Nov 22, 2025

This branch fixes a few issues that came up when integrating nasa/fprime#4473.

  1. On RHEL, the compiler was not happy about calling default constructors with {}; I switched it to ().
  2. The F Prime tracing was not enabling fpp-to-json, so when fpp-to-json was enabled in CI, there was an explosion. I fixed it.
  3. The F Prime tracing was spending time doing builds, but we know those work, so this seemed like wasted effort. As I understand it, all the fpp-to-json work is done in the generate step. So I revised the trace-prime script to do generate only. @LeStarch, please review.

I will make release v3.1.0a12 off of this branch and test it in F Prime CI before merging this PR.

Update F Prime tracing script
Use () instead of {} for default initialization
@bocchino bocchino requested review from Kronos3 and LeStarch November 22, 2025 00:40
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not up-to-speed on the nuance between () and {} but I confirm this, and the script are the changes. Both look good to me.

@bocchino bocchino merged commit fcfa875 into release/v3.1.0 Dec 2, 2025
54 checks passed
@bocchino bocchino deleted the release/v3.1.0a12 branch December 2, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants