Template syntax#999
Merged
Merged
Conversation
Factor out template params into a separate parser Don't require () in template definitions
It's more consistent with the spec. The definition occurs in the analysis, when a syntactic parameter is bound to an argument.
Refactor Add blank line at end of module template def
Rename parameter args
For consistency with existing code
bocchino
approved these changes
May 8, 2026
Collaborator
bocchino
left a comment
bocchino
left a comment
There was a problem hiding this comment.
Looks great! I made some changes to improve consistency with the spec, improve consistency with existing behavior and implementation (e.g., make template parameters work like event and port formal parameters), and eliminate code duplication between similar features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #815