Merged
Conversation
…ead of alpine to fix update-ca-certificates issue
chris-durbin
approved these changes
Feb 27, 2025
Contributor
chris-durbin
left a comment
chris-durbin
left a comment
There was a problem hiding this comment.
Verified successfully locally, harmony in a box, and in a sandbox environment building the images from this branch.
ygliuvt
approved these changes
Feb 27, 2025
Member
ygliuvt
left a comment
ygliuvt
left a comment
There was a problem hiding this comment.
Tested successfully in harmony in a box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-2019
Description
Updates Harmony to latest Node.js 22 minor version (22.14.0) and fixes broken tests by fixing precision on coordinates to six decimal places.
Local Test Steps
(optional) change 22.14.0 in all the package.json files and .nvmrc to 22.5.1, then run
npm installfollowed bynvm run testto see that the code changes work with our current version as well as 22.14.0.I tried to test with the shapefile notebook in the harmony-py repo to make sure I didn't break it, but that uses a production collection.
PR Acceptance Checklist