Skip to content

KMS-705: Correct publisher keyword-event mapping so published and draft keyword CSVs produce complete, CSV-shaped correction objects for every supported scheme. #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgokey merged 5 commits into from
Sep 2, 2026
Merged

KMS-705: Correct publisher keyword-event mapping so published and draft keyword CSVs produce complete, CSV-shaped correction objects for every supported scheme. #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1957387
KMS-705: parse keyword CSVs by named columns and preserve auxiliary m…
Aug 19, 2026
0f38c87
KMS-705: Correct publisher keyword-event mapping so published and dra…
Aug 20, 2026
42db0bc
KMS-705: Updated test coverage.
Aug 21, 2026
4adaabb
KMS-705: Ignore DataFormat corrections when only LongName changes
Aug 21, 2026
9a38be7
KMS-705: Moved AUXILIARY_CSV_HEADERS to constants
Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 92 additions & 0 deletions scripts/local/run_platform_keyword_event_mapping_smoke.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
#!/usr/bin/env node

import assert from 'node:assert/strict'

import {
compareKeywordCsvContent,
createKeywordEvents
} from '../../serverless/src/shared/redis-path-store/getPublishKeywordEvents'

/**
* Verifies platform publisher events keep Short_Name and Long_Name in their correct object fields
* for both a forward keyword change and its revert.
*
* Run with:
* npx vite-node --config vite.config.js scripts/local/run_platform_keyword_event_mapping_smoke.mjs
*/

const keywordUuid = 'f1ccca0a-30c2-4d22-8b78-a1a36b8901b3'
const defaultLongName = 'Greenhouse Gases Observing Satellite'

const createPlatformsCsv = (shortName, longName = defaultLongName) => [
'"Keyword Version: smoke"',
'"Category","Class","Type","Short_Name","Long_Name","UUID"',
`"Platforms","Space-based Platforms","Earth Observation Satellites","${shortName}","${longName}","${keywordUuid}"`
].join('\n')

const buildExpectedKeywordObject = (shortName, longName = defaultLongName) => ({
Category: 'Platforms',
Class: 'Space-based Platforms',
Type: 'Earth Observation Satellites',
ShortName: shortName,
LongName: longName
})

const transitions = [
{
versionName: 'local-amazonia-regression',
oldShortName: 'Amazonia-1',
newShortName: 'Amazonia-1-Test',
longName: 'Amazonia-1'
},
{
versionName: 'local-keyword-republish-v1',
oldShortName: 'GOSAT',
newShortName: 'GOSAT - Test1'
},
{
versionName: 'local-keyword-republish-v2',
oldShortName: 'GOSAT - Test1',
newShortName: 'GOSAT'
}
]

const results = transitions.map((transition) => {
const comparison = compareKeywordCsvContent({
oldCsvContent: createPlatformsCsv(transition.oldShortName, transition.longName),
newCsvContent: createPlatformsCsv(transition.newShortName, transition.longName),
scheme: 'platforms'
})
const events = createKeywordEvents(new Map([
['platforms', comparison]
]))

assert.equal(events.length, 1)

const [keywordEvent] = events
const expectedOldKeywordObject = buildExpectedKeywordObject(
transition.oldShortName,
transition.longName
)
const expectedNewKeywordObject = buildExpectedKeywordObject(
transition.newShortName,
transition.longName
)

assert.equal(keywordEvent.EventType, 'UPDATED')
assert.equal(keywordEvent.UUID, keywordUuid)
assert.deepEqual(keywordEvent.OldKeywordObject, expectedOldKeywordObject)
assert.deepEqual(keywordEvent.NewKeywordObject, expectedNewKeywordObject)

return {
...transition,
oldKeywordObject: keywordEvent.OldKeywordObject,
newKeywordObject: keywordEvent.NewKeywordObject
}
})

console.log('[platform-keyword-event-mapping-smoke] Completed successfully')
console.log(JSON.stringify({
keywordUuid,
results
}, null, 2))
2 changes: 0 additions & 2 deletions serverless/src/getKeywordsTree/__tests__/handler.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,10 @@ vi.mock('@/shared/buildKeywordsTree')
vi.mock('@/shared/filterKeywordTree')
vi.mock('@/shared/filterScienceKeywordsTree')
vi.mock('@/shared/getConceptSchemeDetails')
vi.mock('@/shared/getConfig')
vi.mock('@/shared/getNarrowersMap')
vi.mock('@/shared/getRootConceptForScheme')
vi.mock('@/shared/getRootConceptsForAllSchemes')
vi.mock('@/shared/sortKeywordNodes')
vi.mock('@/shared/sortKeywordSchemes')
vi.mock('@/shared/toTitleCase')
vi.mock('@/shared/getVersionMetadata')
vi.mock('@/shared/redisCacheStore', async () => {
Expand Down
Loading