Skip to content

Conversation

@rjbrown2
Copy link
Contributor

@rjbrown2 rjbrown2 commented Oct 2, 2024

Copy link
Collaborator

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled 325, updated submodules, then pulled nos3#325 branch for psp, osal, and cfe.
I checked out in minimal and full s/c config. Things seem to be in order and everything builds ok. Approving.

@rjbrown2
Copy link
Contributor Author

rjbrown2 commented Oct 7, 2024

Mark found that the nos3-mission.xml is still in sc-minimal-config.xml --- Change this back to sc-full-config.xml

@msuder
Copy link
Contributor

msuder commented Oct 7, 2024

Pulled the 325 branch. Updated submodules. Ran minimal and full scenarios and things worked as planned. Approved for merge.

@jlucas9
Copy link
Contributor

jlucas9 commented Oct 10, 2024

Looks good to me! Put in a minor hotfix to resolve 42 IPC conflicts with the thruster and IMU which seem to be from the dev branch and not this work in order to fully verify 42 launching and sun pointing. Confirmed CFDP class 2 also appears to work via test runner.

Just don't forget to close the required submodule merges and update at the nos3 / top level before merging this in!

@rjbrown2 rjbrown2 merged commit cc96a2e into dev Oct 10, 2024
Copy link
Contributor

@msuder msuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jlucas9 jlucas9 deleted the nos3#325 branch October 10, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants