Skip to content

Conversation

@KushalP17
Copy link
Contributor

Added all remaining telemetry & commands for the following components:
CSS
FSS
IMU
MAG
Reaction Wheel
Star Tracker
Thruster
Radio

(Mostly) all components should start disabled

How to Test:

  1. Clone nos3#731-fprime_components_fidelity
  2. Switch to fprime gsw, fprime fsw, and sc-fprime-config.xml in nos3 cfg
  3. Run various commands for some or all of the listed components
  4. Make sure telemetry & counters show up correctly & behave as expected

Merge PR#729 before this one

Submodules to be merged:
fprime-nos3 - 731-fprime_components_fidelity
generic_css - 731-fprime_components_fidelity
generic_fss - 731-fprime_components_fidelity
generic_imu - 731-fprime_components_fidelity
generic_magnetometer - 731-fprime_components_fidelity
generic_reaction_wheel - 731-fprime_components_fidelity
generic_star_tracker - 731-fprime_components_fidelity
generic_thruster - 731-fprime_components_fidelity
generic_radio - 731-fprime_components_fidelity

Closes #731
Closes #732

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (2f800dc) to head (5566cac).
Report is 34 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #739   +/-   ##
=======================================
  Coverage   73.95%   73.95%           
=======================================
  Files         761      761           
  Lines       93579    93579           
  Branches     6983     6983           
=======================================
  Hits        69207    69207           
  Misses      24372    24372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looks good, please go through and update os_printf() calls with the fprime event message calls, that way we see the messages in fprime-gds. especially if the device is disabled. I saw this on the fss and I am working my way through the others too.

Copy link
Contributor

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending other corrections recommended resolved.

@KushalP17
Copy link
Contributor Author

Should be cleared of os_printf calls now

@zlynch2 zlynch2 self-requested a review June 18, 2025 17:25
Copy link
Collaborator

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed each component, with modifications. Added Functionality is good. Approving. also removed os_printf().

@jlucas9 jlucas9 merged commit 9b2924c into dev Jun 18, 2025
3 checks passed
@jlucas9 jlucas9 deleted the nos3#731-fprime_components_fidelity branch June 18, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fprime Radio Fidelity Fprime Components Fidelity

5 participants