-
Notifications
You must be signed in to change notification settings - Fork 137
[nasa/nos3#731] fprime components fidelity #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #739 +/- ##
=======================================
Coverage 73.95% 73.95%
=======================================
Files 761 761
Lines 93579 93579
Branches 6983 6983
=======================================
Hits 69207 69207
Misses 24372 24372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zlynch2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looks good, please go through and update os_printf() calls with the fprime event message calls, that way we see the messages in fprime-gds. especially if the device is disabled. I saw this on the fss and I am working my way through the others too.
jlucas9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending other corrections recommended resolved.
|
Should be cleared of os_printf calls now |
zlynch2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed each component, with modifications. Added Functionality is good. Approving. also removed os_printf().
Added all remaining telemetry & commands for the following components:
CSS
FSS
IMU
MAG
Reaction Wheel
Star Tracker
Thruster
Radio
(Mostly) all components should start disabled
How to Test:
Merge PR#729 before this one
Submodules to be merged:
fprime-nos3 - 731-fprime_components_fidelity
generic_css - 731-fprime_components_fidelity
generic_fss - 731-fprime_components_fidelity
generic_imu - 731-fprime_components_fidelity
generic_magnetometer - 731-fprime_components_fidelity
generic_reaction_wheel - 731-fprime_components_fidelity
generic_star_tracker - 731-fprime_components_fidelity
generic_thruster - 731-fprime_components_fidelity
generic_radio - 731-fprime_components_fidelity
Closes #731
Closes #732