osal Integration candidate: Caelum-rc4+dev38#1360
Merged
Conversation
Improves default support for return values of sizes other than 32 bits. Previously this required a custom handler for any value that was not a 32 bit integer. With this update any integer value can be used, and a value translation will occur if the size is differnt. Thus boolean values, 8,16, and 64-bit ints can be configured through the same basic API without needing to add a handler.
Fix #1344, UT assert stub return values
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| --StubPtr->Data.Rc.Count; | ||
| /* For "unknown" types the pointer is stored directly - this allows for ANY return type of ANY size, | ||
| * but requires that the caller maintain the buffer in scope until the test completes */ | ||
| StubPtr->Data.Rvc.Buf.IndirectPtr = ValuePtr; |
Check warning
Code scanning / CodeQL-security
Local variable address stored in non-local memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
cFS Bundle Checks
osal Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 20.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey