Skip to content

Conversation

@teubert
Copy link
Contributor

@teubert teubert commented Apr 24, 2025

Battery dataset download was broken due to changes to data.nasa.gov. This PR updates the download links for the datasets

@teubert teubert added the bug Something isn't working label Apr 24, 2025
@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@teubert
Copy link
Contributor Author

teubert commented Apr 24, 2025

Same changes as #213. Approved in other PR

@teubert teubert merged commit fdc74bc into dev Apr 24, 2025
34 checks passed
@teubert teubert deleted the bugs/dataset_download branch April 24, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants