Skip to content

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented May 14, 2020

Describe the contribution
This is #58, resubmitted for fixes:
Addresses ticket #45. Specifically adds new sample_app_cmds.c/.h and sample_app_utils.c/.h files, moves functions out of sample_app.c into the new cmds and utils files. Updates unit tests.
This change makes sample_app a better reference application - structure more closely matches other apps.

Fix #45

Testing performed
TBD

Expected behavior changes
None

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC (resubmit)
Elizabeth Timmons/NASA (implemented)

@skliper
Copy link
Contributor Author

skliper commented May 14, 2020

Currently has CI errors: https://travis-ci.com/github/skliper/cFS/jobs/333841039

@ejtimmon - Do you have time to address these?

@skliper skliper added enhancement New feature or request CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. labels May 14, 2020
@skliper skliper closed this Feb 1, 2021
@skliper skliper deleted the branch nasa:master February 1, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggest refactoring sample_app to more closely match "real" apps.

2 participants