Skip to content

Fix #33, Standardize to SAMPLE_LIB_ namespace prefix #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

Fix #33, Standardize to SAMPLE_LIB_ namespace prefix #34

merged 1 commit into from
Nov 2, 2020

Conversation

@jphickey
Copy link
Contributor

@jphickey jphickey commented Oct 27, 2020

Describe the contribution
Replace inconsistent SAMPLE_ And SAMPLE_Lib prefixes, now all identifiers should start with SAMPLE_LIB_.

Fixes #33

Testing performed
Build and sanity test CFE
Run all unit tests

Expected behavior changes
No impact to behavior, but this also changes the name of the init function from SAMPLE_LibInit to SAMPLE_LIB_Init which affects the CFE startup script.

System(s) tested on
Ubuntu 20.04

Additional context
Needs to be merged with nasa/sample_app#100

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Fix nasa#33, Standardize to SAMPLE_LIB_ namespace prefix
4863b99 
Replace inconsistent SAMPLE_ And SAMPLE_Lib prefixes,
now all identifiers should start with SAMPLE_LIB_.
This was referenced Oct 27, 2020
Closed
Merged
@jphickey jphickey added the CCB:Ready PR or Issue is ready for discussion at the Configuration Control Board (CCB) label Oct 27, 2020
@astrogeco astrogeco removed the CCB:Ready PR or Issue is ready for discussion at the Configuration Control Board (CCB) label Oct 28, 2020
@astrogeco
Copy link
Contributor

astrogeco commented Oct 28, 2020

CCB 2020-10-28 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate October 30, 2020 15:47
@astrogeco astrogeco merged commit 9f4fb66 into nasa:integration-candidate Nov 2, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 2, 2020
@astrogeco
Add samle_lib and sample_app name changes
b01499a 
Add nasa/cFE#968
Add nasa/sample_app#100
Add nasa/sample_lib#34
@astrogeco astrogeco mentioned this pull request Nov 3, 2020
Merged
@jphickey jphickey deleted the fix-33-name-consistency branch June 8, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@zanzaben zanzaben zanzaben approved these changes

@skliper skliper skliper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename files, functions, and variables to match LIBNAME_* pattern

4 participants

@jphickey @astrogeco @zanzaben @skliper