S_sie.resource Field Descriptions

[genti337]

The logic to generate the field descriptions for variables in S_sie.resource ignores any comments that don't end in */.

For example, var1 below parses the field description correctly but var2 would show up at Not Specified when using the trick-sie tool.

double var1; /* (m) Test Variable 1 */
double var2; // (m) Test Variable 2

I traced it back to the following line as the culprit and was able to get the field descriptions for the variable in question if I commented it out, but then it does not strip the */ form the end of the comment. (https://github.com/nasa/trick/blob/master/trick_source/codegen/Interface_Code_Gen/FieldDescription.cpp#L295)

[hchen99]

I'm not able to reproduce the issue. Both // and /* */ work on my end.

[sharmeye]

What version of llvm and what OS are we talking about?

[genti337]

I'm seeing on Mac OS, llvm version 20.1.4.

I checked on my RedHat 8 machine though as well and seeing the same issue there, at least on the HCLS I am.

[hchen99]

Interesting... assuming you're also using the latest Trick.
On Mac 15.7.1 with llvm 21.1.3, tested with the latest Trick using SIM_wheelbot, following works.

    double position[2];              // (m) position 
    double velocity[2];              // (m/s) velocity
    double acceleration[2];          // (m/s2) acceleration

[hchen99]

Oh, I see. Sorry, thought you meant units by mistake. The description is not showing for //

[hchen99]

@genti337 Please give PR #1983 a try to see if you still have the issue when getting a chance.

[genti337]

@hchen99 Pulled that branch and recompiled and I'm seeing the descriptions as expected now when using trick-sie.

Thanks for following up on this, I was using it to script something up to create a variable key from our log files.

[hchen99]

@genti337 Great. Thanks for confirming. What you were trying to do made sense, also helped to find this bug :-)