Skip to content

Conversation

@simtheverse
Copy link

Addresses #2005

Add AlmaLinux 9, Rocky Linux 9, and Oracle Linux 9 to the CI test matrix across all Linux workflow files. Configure RHEL 9-specific dependencies including:

  • Enable CRB (CodeReady Builder) repository instead of PowerTools
  • Install required packages (swig, diffutils, gtest-devel, gmock-devel)
  • Configure EPEL repository for additional dependencies

This extends CI coverage to test against the latest RHEL 9 ecosystem alongside existing RHEL 8 support.

Copilot AI review requested due to automatic review settings December 9, 2025 19:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends CI test coverage to include RHEL 9-based distributions (AlmaLinux 9, Rocky Linux 9, and Oracle Linux 9) across GitHub Actions workflows. The key change is the transition from PowerTools repository (RHEL 8) to CRB (CodeReady Builder) repository (RHEL 9) for installing test dependencies.

  • Adds Rocky Linux 9 and AlmaLinux 9 to CI test matrices
  • Configures RHEL 9-specific dependencies using CRB repository instead of PowerTools
  • Installs required packages (swig, diffutils, gtest-devel, gmock-devel) via EPEL and CRB repositories

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.github/workflows/test_linux.yml Adds Rocky Linux 9 to matrix and RHEL 9-based dependency configuration with CRB repository
.github/workflows/test_linux_py2.yml Adds Rocky Linux 9 to matrix and RHEL 9-based dependency configuration with CRB repository
.github/workflows/trickops.yml Adds dedicated Rocky Linux 9 test job with appropriate dependencies
.github/workflows/report_linux.yml Adds Rocky Linux 9 to test report matrix
.github/workflows/report_linux_py2.yml Adds Rocky Linux 9 to test report matrix
.github/workflows/alt_linux_distros.yml Adds AlmaLinux 9 to matrix and RHEL 9-based dependency configuration with CRB repository
.github/workflows/report_alt_linux_distros.yml Adds AlmaLinux 9 to test report matrix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@brendan-nasa
Copy link
Contributor

thanks for the quick pr! just a few notes:

  • the only workflow's we use are test_linux, report_linux, and trickops. you don't need to touch the others (they're deprecated pending a rewrite of ci)
  • oracle 9's crb repo is ol9_codeready_builder
  • you'll need to differentiate between oracle8 and oracle9 instructions for enabling the crb repo (similar to the rhel-8/9 split)

rebase out the changes to the other files and after you've made your fixes, force push the new changes

@brendan-nasa brendan-nasa self-assigned this Dec 9, 2025
@brendan-nasa brendan-nasa linked an issue Dec 9, 2025 that may be closed by this pull request
Add Rocky Linux 9 and Oracle Linux 9 to the test and report workflows.
Include RHEL 9-specific dependencies configuration with CRB repository
enablement for gtest/gmock installation. Add dedicated trickops unit
test job for Rocky Linux 9 to ensure compatibility with the newer RHEL
version.
- Fix duplicate Oracle Linux 8 entry in test matrix, replace with Oracle Linux 9
- Add Oracle Linux 9 specific gtest installation steps using ol9_codeready_builder repository
- Update Oracle Linux 8 gtest installation to be version-specific instead of OS-only match

This ensures Oracle Linux 9 is properly tested with the correct dependency installation commands.
@simtheverse
Copy link
Author

Done- let me know if that looks right

@coveralls
Copy link

coveralls commented Dec 10, 2025

Coverage Status

coverage: 55.927% (+0.005%) from 55.922%
when pulling 694690e on simtheverse:trick_issue_2005
into 3674388 on nasa:master.

- Removed `swig` from `tag_deps` (which tried to install it with other packages)
- Added `swig` installation to the `conf_pkg` step after enabling the CRB repository
- This ensures the CRB repository is enabled before attempting to install `swig`
@simtheverse
Copy link
Author

I see the CI errors, and I believe my new commits address them.

Separated RHEL-based matrix configurations to prevent Rocky-specific
commands from running on Oracle Linux and vice versa. Common RHEL
dependencies remain shared while install_gtest commands are now
distribution-specific (powertools for Rocky, codeready_builder for Oracle).
Oracle Linux 9 doesn't have a 'crb' repository - it uses 'ol9_codeready_builder'.
Moved the crb enablement from generic RHEL 9 config to Rocky Linux 9 specific
config to prevent "No matching repo to modify: crb" error.
- Install epel-release and update repos before enabling CRB on Rocky 9
- Add dnf-command(config-manager) plugin installation for Rocky 9
- Move swig from conf_pkg to tag_deps for Rocky 9 to ensure proper ordering
- Add missing swig dependency to Oracle Linux 9 configuration

These changes ensure package repositories are properly configured before
attempting to enable additional repos and install dependencies, fixing
build failures on Rocky Linux 9 and Oracle Linux 9 environments.
Add prerequisite steps to enable EPEL repository and install dnf config-manager before enabling ol9_codeready_builder repository. This ensures the required tools are available before attempting to configure additional repositories and install gtest dependencies on OracleLinux 9.

Changes:
- Install epel-release package
- Update dnf package database
- Install dnf-command(config-manager) plugin
- Reorganize steps into conf_pkg and install_gtest sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding Rocky/RHEL 9 to Linux CI tests

3 participants