Add typemap for command_line_args_get_argv #2009
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ddj116 @excaliburtb can y'all check this pr and see if it fixes y'all's issues |
Contributor
|
Thinking of adding tests for command_line_args_get_argc and command_line_args_get_argv in the CommandLineArguments test folder, and also adding tests to input.py under SIM_test_output_dir. |
Contributor
Can confirm this PR fixes the Ramtares use-case. Agree with @hchen99 if y'all can add a test for this it'll prevent it from ever popping up again. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2008