Skip to content

Update Mtv to correctly use condition_list and action_list#2092

Merged
sharmeye merged 6 commits intomasterfrom
bugfix/2020-mtv-failing-to-launch-variable-server-cant-find-cond-and-act
Apr 16, 2026
Merged

Update Mtv to correctly use condition_list and action_list#2092
sharmeye merged 6 commits intomasterfrom
bugfix/2020-mtv-failing-to-launch-variable-server-cant-find-cond-and-act

Conversation

@brendan-nasa
Copy link
Copy Markdown
Contributor

test doesn't run the gui directly but opens a socket and sends the same fields that Mtv uses

@brendan-nasa brendan-nasa linked an issue Apr 15, 2026 that may be closed by this pull request
@brendan-nasa brendan-nasa force-pushed the bugfix/2020-mtv-failing-to-launch-variable-server-cant-find-cond-and-act branch from 2d04a6f to 8139a13 Compare April 15, 2026 22:27
Comment thread test_sims.yml
Comment on lines -2 to 3
SIM_alloc_test:
path: test/SIM_alloc_test
SIM_alloc_test:
path: test/SIM_alloc_test
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this in here twice?

Comment on lines -280 to +286
for (int jj=0; jj < mtv_events.get(ii).cond_count; jj++) {
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" +ii+ "][0].cond[" +jj+ "].enabled\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" +ii+ "][0].cond[" +jj+ "].fired_time\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" +ii+ "][0].cond[" +jj+ "].fired_count\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" +ii+ "][0].cond[" +jj+ "].hold\"); ";
for (int jj = 0; jj < mtv_events.get(ii).cond_count; jj++) {
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" + ii + "][0].condition_list[" + jj + "].enabled\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" + ii + "][0].condition_list[" + jj + "].fired_time\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" + ii + "][0].condition_list[" + jj + "].fired_count\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" + ii + "][0].condition_list[" + jj + "].hold\"); ";
mtv_var_count += 4;
}
for (int jj=0; jj < mtv_events.get(ii).act_count; jj++) {
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" +ii+ "][0].act[" +jj+ "].enabled\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" +ii+ "][0].act[" +jj+ "].ran_time\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" +ii+ "][0].act[" +jj+ "].ran_count\"); ";
for (int jj = 0; jj < mtv_events.get(ii).act_count; jj++) {
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" + ii + "][0].action_list[" + jj + "].enabled\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" + ii + "][0].action_list[" + jj + "].ran_time\"); ";
event_vars += "trick.var_add(\"trick_ip.mtv.mtv_list[" + ii + "][0].action_list[" + jj + "].ran_count\"); ";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the important lines in MtvApp

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 15, 2026

Coverage Status

coverage: 56.605% (+0.8%) from 55.802% — bugfix/2020-mtv-failing-to-launch-variable-server-cant-find-cond-and-act into master

@sharmeye sharmeye merged commit 6fd5666 into master Apr 16, 2026
9 checks passed
@sharmeye sharmeye deleted the bugfix/2020-mtv-failing-to-launch-variable-server-cant-find-cond-and-act branch April 16, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MTV failing to launch. Variable Server cant find cond[] and act[]

3 participants