Place Trickified code in the correct Python module#2102
Open
ninotarantino wants to merge 1 commit intonasa:masterfrom
Open
Place Trickified code in the correct Python module#2102ninotarantino wants to merge 1 commit intonasa:masterfrom
ninotarantino wants to merge 1 commit intonasa:masterfrom
Conversation
Previously, any code with the PYTHON_MODULE Trick header field was not placed into that Python module if it was part of a Trickified library. Refs nasa#2101.
|
Coverage is 56.79% — ninotarantino:trickified-code-in-correct-python-module into nasa:master. No base build found for |
Contributor
Author
|
@hchen99 @Pherring04 this is ready for review. I noticed an issue where my Trickified code wasn't being placed in the |
Contributor
|
Thanks @ninotarantino will let you know if anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue where Trickified code was not placed into the
PYTHON_MODULEspecified in its header files.Closes #2101.