chore: fmt and clippy cleanup across all crates#4
Closed
adolfousier wants to merge 1 commit into
Closed
Conversation
Run cargo fmt --all and fix all clippy warnings:
- Replace map_or(false, ...) with is_some_and(...)
- Replace map_or(true, ...) with is_none_or(...)
- Replace filter().next_back() with rfind()
- Replace match with single arm to if let
- Add #[derive(Default)] with #[default] on enums
- Remove dead code (unused variables, unused imports)
- Simplify format!("{}", x) to x.to_string()
- Replace .clamp() for min/max chains
- Fix needless borrows and other minor lints
RickSanchez88E
pushed a commit
to RickSanchez88E/AutoCLI
that referenced
this pull request
May 16, 2026
Free Cloudflare zones get Universal SSL covering only <zone> + one-level
*.<zone>. Two-level subdomains like vnc.autocli.<zone> handshake-fail
('Unauthorized' / sslv3 alert) until the operator upgrades to Pro,
Total TLS, or ACM.
Rename across SPEC / PLAN / README:
vnc.autocli.<zone> -> autocli-vnc.<zone>
cdp.autocli.<zone> -> autocli-cdp.<zone>
api.autocli.<zone> -> autocli-api.<zone>
grafana.autocli.<zone> -> autocli-grafana.<zone>
§9 risk nashsu#4 now documents the Free-plan SSL constraint as the reason for
the flat naming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is completely optional, purely mechanical lint fixes if you want, test it. Cheers
Summary
cargo fmt --alland fix allclippy --all-features -D warningsacross every cratemap_or,filter().next_back(), single-armmatch) with idiomatic Rust (is_some_and,rfind,if let)#[derive(Default)]with#[default]on enums (Strategy,ArgType,ScrollDirection)format!("{}", x)→x.to_string(),.min().max()→.clamp(), needless borrowsTest plan
cargo fmt --all— no changes neededcargo clippy --workspace --all-features -- -D warnings— zero warnings