Replace frictionless with pandas#136
Merged
Merged
Conversation
phargogh
approved these changes
May 6, 2026
Member
phargogh
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks @davemfish ! Looks like there are a few ways we could potentially be detecting table dialects (e.g. csv.Sniffer), but pandas seems to have the easiest-to-use column type inference, and I fully agree that pandas is likely to already exist in the environments where geometamaker is likely to be installed.
Farewell, frictionless!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frictionless has proven to not be the right tool for the job, and not worth the weight of using it as a dependency. We can use
pandasinstead, which has proven to be a reliable package and is often used in the same contexts asgeometamakeranyway.In giving up
frictionlesswe give up its ability to detect the tabular schema of arbitrary files. So, we are now being more explicit about the tabular file formats that we support (csvandtsv). Essentially, any text file with a character delimiter can be supported. Pandas can auto-detect the dialect of the file (the separator and quote characters).Fixes #130