REC: always write out all userday metrics#1918
Merged
davemfish merged 5 commits intonatcap:release/3.16.0from May 15, 2025
Merged
REC: always write out all userday metrics#1918davemfish merged 5 commits intonatcap:release/3.16.0from
davemfish merged 5 commits intonatcap:release/3.16.0from
Conversation
Contributor
Author
|
The test failures here are unrelated. They are the HRA failure that is awaiting #1881 |
davemfish
commented
May 13, 2025
| # andros_aoi.shp fits 71 hexes at 20000 meters cell size | ||
| self.assertEqual(n_features, 71) | ||
|
|
||
| def test_existing_regression_coef(self): |
Contributor
Author
There was a problem hiding this comment.
I deleted this test because the _schedule_predictor_data_processing function no longer encapsulates the logic to delete the pre-existing output, that was moved elsewhere.
claire-simpson
approved these changes
May 14, 2025
Contributor
claire-simpson
left a comment
claire-simpson
left a comment
There was a problem hiding this comment.
This all looks great! Are we happy to merge even with the failing tests, since we know that will be fixed in PR 1882?
Contributor
Author
Thanks! Yes, it's okay to merge when we know the failures are unrelated. I'll go ahead and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always write out final userday variables to
regression_data.gpkgeven if not proceeding to thecompute_regressionportion of the model.Fixes #1893
UG update: natcap/invest.users-guide#179
Checklist
- [ ] Tested the Workbench UI (if relevant)