fix(build): make patch utility work with zig 0.15.2 #180
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takeDelimiterExclusive doesn't advance the seek position after the newline anymore, leading to failures. This is noticed when building with -Dlang=lua51
Contributor
Author
|
I think the zig-master failure is unrelated (master changed translate-c implementation recently, since the main branch here was last tested in the middle of september) |
Owner
|
Thanks for catching this! I'll merge even with the failure because this doesn't make the state of master any worse. That can be fixed elsewhere... |
Collaborator
|
looks like the main master failure will be fixed by either ziglang/translate-c#215 or ziglang/translate-c#202. after that there's a failure related to changes in how indexing into vectors is allowed; I'll push a fix now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
takeDelimiterExclusive doesn't advance the seek position after the newline anymore, leading to failures. This is noticed when building with -Dlang=lua51