fix(build): use cross-platform init.args.iterateAllocator()#206
Merged
natecraddock merged 1 commit intonatecraddock:mainfrom Apr 17, 2026
Merged
fix(build): use cross-platform init.args.iterateAllocator()#206natecraddock merged 1 commit intonatecraddock:mainfrom
natecraddock merged 1 commit intonatecraddock:mainfrom
Conversation
When running on windows an allocator is required:
+- run exe minilua (buildvm_arch.h)
+- run cmd
+- run exe patch (dynasm-patched.lua)
+- compile exe patch Debug native 1 errors
...\zig-x86_64-windows-0.16.0\lib\std\process\Args.zig:39:36: error: In Windows, use initAllocator instead.
if (native_os == .windows) @CompileError("In Windows, use initAllocator instead.");
As this one-shot script uses an arena, there is no deinit() call
Merged
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running on windows an allocator is required:
As this one-shot script uses an arena, there is no deinit() call