toStruct: set a field to null if the field is nullable and isn't getting set#207
Merged
natecraddock merged 2 commits intonatecraddock:mainfrom Apr 24, 2026
Merged
Conversation
Squibid
changed the title
Contributor
Author
|
wow didn't even realize that this bug was already found in #171, I can implement the possible solution from there if no one else wants to otherwise I'll close this and let someone else take a shot at it. |
Owner
|
Thanks! I was going to work on #171 soon, but glad to get some help. I think I'd prefer the solution in that issue, so if you want to simplify yours to just be the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the struct in
toStructis created from undefined memory it does need to be set to something to not have undefined behavior. Maybe it'd be a good idea to make nothing getting set unreachable or perhaps panic?