Make IUnhandledExceptionHandler optional and always call StopApplication #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ICommandLineService cliService, | ||
| IConsole console, | ||
| IUnhandledExceptionHandler unhandledExceptionHandler) | ||
| IUnhandledExceptionHandler unhandledExceptionHandler = null) |
Owner
There was a problem hiding this comment.
Why is this necessary? This service should always be defined, right?
CommandLineUtils/src/Hosting.CommandLine/HostBuilderExtensions.cs
Lines 42 to 43 in 1bdec5a
Contributor
Author
There was a problem hiding this comment.
It currently is. Ultimately I hoped that #196 would render the handler optional and I then would have removed the quoted line. Also I wanted to know if you can have optionally injected dependencies and it is consistent with the call in
Owner
|
Thanks, Matthias! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as everything works out as intended StopApplication is called, but if not the Host will probably never stop on it's own.