Skip to content

Make IUnhandledExceptionHandler optional and always call StopApplication #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natemcmaster merged 1 commit into from
Dec 19, 2018
Merged

Make IUnhandledExceptionHandler optional and always call StopApplication #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Hosting.CommandLine/Internal/CommandLineLifetime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ internal class CommandLineLifetime : IHostLifetime, IDisposable
public CommandLineLifetime(IApplicationLifetime applicationLifetime,
ICommandLineService cliService,
IConsole console,
IUnhandledExceptionHandler unhandledExceptionHandler)
IUnhandledExceptionHandler unhandledExceptionHandler = null)
Copy link
Owner

@natemcmaster natemcmaster Dec 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? This service should always be defined, right?

CommandLineUtils/src/Hosting.CommandLine/HostBuilderExtensions.cs

Lines 42 to 43 in 1bdec5a

services
.TryAddSingleton<IUnhandledExceptionHandler>(exceptionHandler);

Copy link
Contributor Author

@TheConstructor TheConstructor Dec 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It currently is. Ultimately I hoped that #196 would render the handler optional and I then would have removed the quoted line. Also I wanted to know if you can have optionally injected dependencies and it is consistent with the call in

CommandLineUtils/src/Hosting.CommandLine/Internal/CommandLineLifetime.cs

Line 69 in 1bdec5a

if (_unhandledExceptionHandler != null)

{
_applicationLifetime = applicationLifetime;
_cliService = cliService;
Expand Down Expand Up @@ -75,8 +75,10 @@ public Task WaitForStartAsync(CancellationToken cancellationToken)
ExceptionDispatchInfo.Capture(e).Throw();
}
}

_applicationLifetime.StopApplication();
finally
{
_applicationLifetime.StopApplication();
}
});

// Ensures services are disposed before the application exits.
Expand Down