Skip to content

Conversation

@natemcmaster
Copy link
Owner

cc @TheConstructor @vlm---

We need to add support for cancellation tokens, but that won't happen until after 2.3. In the meantime, this removes the Task.Run which should resolve #195

@TheConstructor
Copy link
Contributor

This is shorter than #196. I don't know which one is a better solution to #195. Guess most important would be to know how/if async-await on top-level is handled differently from GetAwaiter().GetResult() further down the line.

@natemcmaster natemcmaster merged commit ba2d69d into master Dec 19, 2018
@natemcmaster natemcmaster deleted the fix/195 branch December 19, 2018 07:30
@natemcmaster
Copy link
Owner Author

Let's start with this and see if it solves @vlm---'s issue. I think this library overall needs to revisit its async support, but that's a mess to wrangle later...

@vlm--- can you try out build 2.3.0-rtm.469 or higher from this myget feed? https://www.myget.org/feed/natemcmaster/package/nuget/McMaster.Extensions.CommandLineUtils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run on same thread in generic host

3 participants