Skip to content

Prep 5.1 release#606

Merged
natemcmaster merged 5 commits intomainfrom
prep-5.1-release
Apr 5, 2026
Merged

Prep 5.1 release#606
natemcmaster merged 5 commits intomainfrom
prep-5.1-release

Conversation

@natemcmaster
Copy link
Copy Markdown
Owner

No description provided.

Add release notes, changelog entry, version bump, and a sample project
demonstrating keyed dependency injection via [FromKeyedServices].

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude bot commented Apr 5, 2026

Code Review

Thanks for putting this release together! I've reviewed the full diff and no substantive issues found. Here's a summary of what's covered:

  • Version bump 5.0.1 → 5.1.0 with changelog and release notes for the keyed DI feature (Add support for keyed DI and update target frameworks #560)
  • Dependency updates — Microsoft.Extensions.* 10.0.3→10.0.5, coverlet 6.0.4→8.0.1, FluentAssertions 8.8→8.9, Microsoft.NET.Test.Sdk 18.0.1→18.3.0, SourceLink 10.0.103→10.0.201
  • Tooling cleanup — removed dotnet-format tool entry in favor of built-in dotnet format; enabled IDE0005 (unnecessary usings) as a warning; added GenerateDocumentationFile in test props to support the analyzer
  • Preprocessor directive cleanup — removed NET472_OR_GREATER branches from #if guards around [RequiresUnreferencedCode] and [DynamicallyAccessedMembers] attributes (safe since the project targets .NET 6.0+ only, and PolySharp is configured with PolySharpIncludeRuntimeSupportedAttributes)
  • DictionaryExtensions.cs restructure — correctly scopes the TryAdd polyfill to NET472_OR_GREATER only, with #error for unexpected targets
  • Samples — new keyed DI sample, license headers added, wildcard *.csproj reference fixed to explicit filename, unnecessary usings removed
  • Directory.Build.targets — good fix changing *.csproj glob to explicit McMaster.Extensions.CommandLineUtils.csproj to avoid matching unintended projects

Everything looks correct and consistent. Ship it! 🚢


Automated review by Claude Code

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.00%. Comparing base (758fcca) to head (13814e4).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   80.32%   80.00%   -0.33%     
==========================================
  Files         121      120       -1     
  Lines        4031     4061      +30     
  Branches      875      879       +4     
==========================================
+ Hits         3238     3249      +11     
- Misses        616      623       +7     
- Partials      177      189      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

natemcmaster and others added 4 commits April 4, 2026 20:58
Use pull_request_target for auto-reviews so the workflow runs in the
base repo context with access to secrets, while safely checking out
only the base branch. Remove fork restrictions from the interactive
workflow since those events already run in the base repo context.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@natemcmaster natemcmaster merged commit 13814e4 into main Apr 5, 2026
11 of 12 checks passed
@natemcmaster natemcmaster deleted the prep-5.1-release branch April 5, 2026 04:15
This was referenced Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant