fix: use lax IDNA profile to support underscores in domains#145
Merged
natesales merged 1 commit intonatesales:mainfrom Dec 8, 2025
Merged
fix: use lax IDNA profile to support underscores in domains#145natesales merged 1 commit intonatesales:mainfrom
natesales merged 1 commit intonatesales:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where domains containing underscores (e.g. _smtp._tls.example.com) were being incorrectly rewritten by the previous strings.ReplaceAll hack.
Instead of manual string manipulation, this change switches to the standard golang.org/x/net/idna library with a custom profile (StrictDomainName(false)). This disables STD3 ASCII rules, correctly allowing non-LDH characters like underscores (valid in DNS records) while ensuring proper Punycode conversion for internationalized domains.
Changes
Verification
Verified with the following cases:
Related Issues
Fixes #141
Summary by cubic
Switches to a lax IDNA profile to correctly allow underscores in domain labels and avoid rewriting them. Keeps proper Punycode conversion for internationalized domains.
Written for commit 01e44c9. Summary will update automatically on new commits.