This repository was archived by the owner on May 6, 2024. It is now read-only.
Shebang overrides plus docs#46
Merged
nathom merged 4 commits intonathom:devfrom Nov 23, 2021
mohamed-abdelnour:shebang-overrides-plus-docs
Merged
Shebang overrides plus docs#46nathom merged 4 commits intonathom:devfrom mohamed-abdelnour:shebang-overrides-plus-docs
nathom merged 4 commits intonathom:devfrom
mohamed-abdelnour:shebang-overrides-plus-docs
Conversation
nathom
reviewed
Nov 20, 2021
lua/filetype/init.lua
Outdated
| if shebang then | ||
| shebang = builtin_map.shebang[shebang] or shebang | ||
| shebang = custom_map.shebang[shebang] | ||
| or builtin_map.shebang[shebang] |
Owner
There was a problem hiding this comment.
builtin_map was removed entirely, so indexing it will cause an error.
Contributor
Author
There was a problem hiding this comment.
Yes, I'll update the PR with c712344; just wanted to ask first in case you were still working on it.
Owner
|
Thanks! I'll merge after you fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @nathom, thank you for the awesome plugin!
This is a small PR to allow configuring extra shebang associations. I think it would be nice to have this so that users can easily customise shebangs without having to update the main repository.
If you're interested in merging this, please tell me whether or not to keep 379daf5. I'll drop the commit and force push if you don't think it's necessary.
Another thing to note, there is currently a small bug with shebangs on the
devbranch after 7837d23; here is the error message:I fixed it in c712344 and can update this PR with the fix or open a new one.