This repository was archived by the owner on May 6, 2024. It is now read-only.
Conversation
`try_lookup` returns true when query is in map even if set_filetype returns false. For that reason, `function_literal` using `try_lookup` works. On the other hand, `function_complex` using `try_regex` did not work because `set_filetype` returns false and `try_regex` returns false. This commit resolve the issue by make it always return true when regexp matches the absolute_path. This behavior is consistent with `try_lookup`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try_lookupreturns true when query is in map even if set_filetypereturns false.
For that reason,
function_literalusingtry_lookupworks.On the other hand,
function_complexusingtry_regexdid not workbecause
set_filetypereturns false andtry_regexreturns false.This commit resolve the issue by make it always return true when regexp matches the absolute_path.
This behavior is consistent with
try_lookup.Conflicts #55
but #55 did not work for me. Sorry #55 worked, but this is backward(explained in README.md) compatibility PR.