Skip to content

Conversation

@wangw469
Copy link
Contributor

@wangw469 wangw469 commented Dec 7, 2024

fix #751
fix #752
fix #767

Fix error when fetch app_id and/or secrets:
ValueError: list.remove(x): x not in list

Try to fix this error by check if vals contains empty string:

        if "" in vals:
            vals.remove("")

@wangw469 wangw469 changed the title fix #751 Fix error when fetch app_id and/or secrets: ValueError: list.remove(x): x not in list Dec 7, 2024
@wangw469 wangw469 changed the title Fix error when fetch app_id and/or secrets: ValueError: list.remove(x): x not in list Fix error when fetch app_id and/or secrets: ValueError: list.remove(x): x not in list (fix #751) Dec 7, 2024
@wangw469 wangw469 changed the title Fix error when fetch app_id and/or secrets: ValueError: list.remove(x): x not in list (fix #751) Fix error when fetch app_id and/or secrets: ValueError: list.remove(x): x not in list (fix #751 #767 #751) Dec 7, 2024
@wangw469 wangw469 changed the title Fix error when fetch app_id and/or secrets: ValueError: list.remove(x): x not in list (fix #751 #767 #751) Fix error when fetch app_id and/or secrets: ValueError: list.remove(x): x not in list (fix #751 #767 #752) Dec 7, 2024
@wangw469
Copy link
Contributor Author

wangw469 commented Dec 7, 2024

@nathom Thanks a lot for making such a great tool, I love it!

As a new user, I encounter this issue and it almost scare me away.
Since it will affect all user don't have app_id and secrets inside config file, maybe we can fix it and release a new version?

@nathom
Copy link
Owner

nathom commented Dec 7, 2024

Looks good. Thanks!

@nathom nathom merged commit e44ded4 into nathom:dev Dec 7, 2024
@nathom
Copy link
Owner

nathom commented Dec 7, 2024

@wangw469 I haven't got time to work on this for the past few months. I will test everything and make a public release in ~2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] "X not in list" [BUG] ValueError: list.remove(x): x not in list [BUG] Can't fetch app_id and/or secrets

2 participants