Set the max tokens as the default is set to 4086#2
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| LANGUAGE: English | ||
| LOG_LEVEL: debug No newline at end of file | ||
| LOG_LEVEL: debug | ||
| max_tokens: 10000 No newline at end of file |
There was a problem hiding this comment.
Adding max_tokens: 10000 seems reasonable, but consider:
- Cost: Increasing the token limit directly impacts the cost of API calls. Is 10000 tokens justified for the expected use cases? Could this lead to unexpected high costs?
- Context Length of Model: Verify that the underlying LLM supports a context window of at least 10000 tokens. If it doesn't, the request will likely be truncated (and potentially cause unexpected behavior) or fail outright. You should select a maximum token value that is compatible with the model.
- Default Value/Configuration: Is 10000 the right default? It's generally a good practice to allow configuring this parameter, perhaps via an environment variable or command-line argument, so users can tailor it to their needs and budget.
- Error Handling: It would be good to include some error handling in the process. For example check if the value of
max_tokensis positive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.