Chore - Migrate react-native-render-html with history #14
Conversation
Useful to compute the collapsed top margin for each member of a `TNode` list.
Useful for rendering individual nodes in isolation, e.g. in the `renderItem` prop of a `FlatList`.
Avoid re-renders of children of interative / dynamic custom renderers.
Keys don't need to be handled deeper in the tree, only when returning arrays of React nodes. This was a legacy of v5, where custom renderers were functions. Now that any custom renderer is wrapped in a `TNodeRenderer` which has its own key, there is no need to use this key in custom renderers.
…nction Using deep equality would cause massive performance issues for the `dom` source type.
There was a problem hiding this comment.
This kind of decision should be very deliberate; perhaps you have more technical context to share? To be clear, I'm not against it, I just want to understand the rationale.
There was a problem hiding this comment.
It's because pnp does not work with react-native applications, they simply do not run, see here: https://yarnpkg.com/features/pnp#when-creating-a-new-project
It wasn't an issue before, since there were no apps in the repo, but now we've decided that it probably is better to keep an example app (and the website) in the repository, to make the development easier. We put having sample apps in the repo over keeping yarn pnp
There was a problem hiding this comment.
LGTM, thanks for the context!
…-html-with-history' into chore/migrate-render-html-with-history
5ZYSZ3K
force-pushed
the
chore/migrate-render-html-with-history
branch
from
b0cc2d5 to
bbe4cb1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 57 57
Lines 1148 1153 +5
Branches 313 318 +5
=======================================
+ Hits 1140 1145 +5
Misses 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Upgrade RN, fix tests for render-html
Upgrading dependencies and running apps/discovery
This is a follow up to: #13, just made with a source branch from this repo, to b able to preview targeting PRs in one place
Description
This PR is meant to move the contents of
react-native-render-htmlto this library with no other changesUltimately I decided to move
packages/render-htmlandappsdirectories to the repopackages/render-htmlcontains the core logic ofreact-native-render-htmlappscontains testing applications that may be helpfulI plan to create pull requests based off of this one to actually get it to work
References
Repository merge with history guide: https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/
react-native-render-htmlrepo: https://github.com/meliorence/react-native-render-htmlRepository merge with history guide: https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/
react-native-render-html repo: https://github.com/meliorence/react-native-render-html