Chore - Migrate react-native-render-html with history #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful to customize the color, fontSize, fontFamily... etc.
Contributor
|
@5ZYSZ3K I converted to draft to make it clear this is a WIP. Please re-request for review when it's ready to be merged. |
Closed
Collaborator
Author
|
@jsamr there are still issues with bundling the website, but we decided to drop it for now. I think that I would try to release it in early alpha before christmas, so that we would have it prepared for a full major release which would take place in a new year |
Contributor
|
@5ZYSZ3K That sounds absolutely reasonable 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to: #13, just made with a source branch from this repo, to b able to preview targeting PRs in one place
Description
This PR is meant to move the contents of
react-native-render-htmlto this library with no other changesUltimately I decided to move
packages/render-htmlandappsdirectories to the repopackages/render-htmlcontains the core logic ofreact-native-render-htmlappscontains testing applications that may be helpfulI plan to create pull requests based off of this one to actually get it to work
References
Repository merge with history guide: https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/
react-native-render-htmlrepo: https://github.com/meliorence/react-native-render-htmlRepository merge with history guide: https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/
react-native-render-html repo: https://github.com/meliorence/react-native-render-html